components/pdforge/common/utils.mjs (1)

33-48: Optimize clearObj function to avoid O(n²) complexity

The spread syntax in the accumulator of reduce() can lead to O(n²) time complexity for large objects, as flagged by static analysis.

Consider refactoring to avoid the spread operator on the accumulator:

export const clearObj = (obj) => {
  return Object.entries(obj)
    .filter(([, v]) => (v != null && v != "" && JSON.stringify(v) != "{}"))
    .reduce((acc, [k, v]) => {
-     return {
-       ...acc,
-       [k]: (!Array.isArray(v) && v === Object(v))
-         ? clearObj(v)
-         : v,
-     };
+     acc[k] = (!Array.isArray(v) && v === Object(v))
+       ? clearObj(v)
+       : v;
+     return acc;
    }, {});
};

🧰 Tools

🪛 Biome (1.9.4)

[error] 43-43: Avoid the use of spread (...) syntax on accumulators.

Spread syntax should be avoided on accumulators (like those in .reduce) because it causes a time complexity of O(n^2).
Consider methods such as .splice or .push instead.

(lint/performance/noAccumulatingSpread)

components/pdforge/actions/common/base.mjs (1)

79-92: Remove redundant webhook assignment

The webhook property is being set twice (once in the initial data object and again in the asyncMode condition).

const data = {
  ...this.getAdditionalData(),
  convertToImage: this.convertToImage,
  webhook: this.webhook,
};

if (this.saveS3) {
  data.s3Bucked = this.s3Bucked;
  data.s3Key = this.s3Key;
}

if (this.asyncMode) {
-  data.webhook = this.webhook;
}

components/pdforge/actions/generate-pdf-from-html/generate-pdf-from-html.mjs (2)

8-8: Consider adding more details to documentation link

The documentation link is helpful, but it would be more user-friendly to specify what information can be found there (e.g., "See the documentation for API details and examples").

---

35-39: Improve success message with file details

The success message is clear but could be enhanced by including more details about the generated file, such as file name or size if available from the response.

  getSummary({ convertToImage }) {
    return `${convertToImage
      ? "PNG"
      : "PDF"} successfully generated from provided HTML content.`;
  },

components/pdforge/pdforge.app.mjs (3)

21-21: Fix typo in description

There's a typo in the fileName description: "direcrtory" should be "directory".

-  description: "The filename without extension for saving the file in the `/tmp` direcrtory",
+  description: "The filename without extension for saving the file in the `/tmp` directory",

---

6-27: Add validation for URL and file properties

Consider adding validation for the webhook URL format and potentially for S3 bucket naming patterns to prevent runtime errors.

For the webhook property, you could add:

  webhook: {
    type: "string",
    label: "Webhook URL",
    description: "The URL of your webhook endpoint",
+   pattern: "^https?://.*",
+   validatePattern: true,
  },

---

40-48: Add error handling to request method

The _makeRequest method could benefit from error handling to provide more descriptive error messages specific to pdforge API errors.

  _makeRequest({
    $ = this, baseUrl, removeHeader, path = "", ...opts
  }) {
-   return axios($, {
-     url: this._baseUrl(baseUrl) + path,
-     headers: this._headers(removeHeader),
-     ...opts,
-   });
+   return axios($, {
+     url: this._baseUrl(baseUrl) + path,
+     headers: this._headers(removeHeader),
+     ...opts,
+   }).catch(err => {
+     const status = err.response?.status;
+     const message = err.response?.data?.message || err.message;
+     throw new Error(`pdforge API error (${status}): ${message}`);
+   });
  },

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting